Skip to content

refactor(index): remove redundant regex non-capture group#179

Merged
Fdawgs merged 1 commit into
mainfrom
refactor/capture-group
Nov 28, 2025
Merged

refactor(index): remove redundant regex non-capture group#179
Fdawgs merged 1 commit into
mainfrom
refactor/capture-group

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented Nov 28, 2025

Checklist

Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies a regex pattern by removing an unnecessary non-capturing group around the literal string "basic". The change refactors (?:basic) to just basic in the authScheme constant, which is then interpolated into larger regex patterns for HTTP Basic authentication credential validation.

  • Removed redundant non-capturing group syntax from the authScheme constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Fdawgs Fdawgs merged commit d2fe3f9 into main Nov 28, 2025
23 checks passed
@Fdawgs Fdawgs deleted the refactor/capture-group branch November 28, 2025 14:08
@Eomm
Copy link
Copy Markdown
Member

Eomm commented Nov 28, 2025

I know these are chores, but please wait for an approve before merging 🙏🏼

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants